Added a list template class, seems to work pretty well for now, I may have

forgotten proper cleanup in the deconstructor, but besides that you can do
almost everything you need.  I'll make a slist/stack next, probably with the
same basic code, just a different structure (not doubley-linked).

The xml system from old-libbu++ is almost completely converted, I was going to
re-write it, but this seemed easier at first, it may not have been, we'll see.
It almost parses everything again, and almost outputs again, and it does use
streams now.

The FString is partway to doing minimum chunk allocations, so that adding
single-characters will be really fast up to the minimum chunk size.  I also
figured out how to add this optimization without any extra variables taking
up space, and it's optional in the template, which is cool.  You can specify
the size of the blocks (default 256 bytes), if it's 0 then they'll be like the
old FString, 1 chunk per operation.

The next FString update should be allowing efficient removal from the begining
of the string by faking it, and simply moving a secondary base pointer ahead,
and then optimizing appends after that fact to simply move the existing data
around if you shouldn't have to re-allocate (alla FlexBuf).  The final fun
addition that I'm planning is a simple switch in the template (boolean) that
will switch an FString into a thread-safe mode without changing the interface
or anything that you can do with them at all.  It may increasing memory usage,
but they should still be better than std::strings, and totally thread-safe.

The best part of that is that if it's done with a boolean template parameter and
if statements that only test that parameter controlling flow, the code that you
don't want (threadsafe/non-threadsafe) won't be included at all
post-optimization.

1 files changed, 28 insertions, 34 deletions

diff --git a/src/xmlwriter.cpp b/src/xmlwriter.cpp
index 56880b6..7dc6ca9 100644
--- a/src/xmlwriter.cpp
+++ b/src/xmlwriter.cpp
@@ -2,17 +2,10 @@
 #include <stdlib.h>
 #include "xmlwriter.h"
 
-XmlWriter::XmlWriter( const char *sIndent, XmlNode *pRoot ) :
-        XmlDocument( pRoot )
+XmlWriter::XmlWriter( const Bu::FString &sIndent, XmlNode *pRoot ) :
+        XmlDocument( pRoot ),
+        sIndent( sIndent )
 {
-        if( sIndent == NULL )
-        {
-                this->sIndent = "";
-        }
-        else
-        {
-                this->sIndent = sIndent;
-        }
 }
 
 XmlWriter::~XmlWriter()
@@ -24,7 +17,7 @@ void XmlWriter::write()
         write( getRoot(), sIndent.c_str() );
 }
 
-void XmlWriter::write( XmlNode *pRoot, const char *sIndent )
+void XmlWriter::write( XmlNode *pRoot, const Bu::FString &sIndent )
 {
         writeNode( pRoot, 0, sIndent );
 }
@@ -39,7 +32,7 @@ void XmlWriter::closeNode()
         }
 }
 
-void XmlWriter::writeIndent( int nIndent, const char *sIndent )
+void XmlWriter::writeIndent( int nIndent, const Bu::FString &sIndent )
 {
         if( sIndent == NULL ) return;
         for( int j = 0; j < nIndent; j++ )
@@ -48,26 +41,27 @@ void XmlWriter::writeIndent( int nIndent, const char *sIndent )
         }
 }
 
-std::string XmlWriter::escape( std::string sIn )
+Bu::FString XmlWriter::escape( const Bu::FString &sIn )
 {
-        std::string sOut;
+        Bu::FString sOut;
 
-        std::string::const_iterator i;
-        for( i = sIn.begin(); i != sIn.end(); i++ )
+        int nMax = sIn.getSize();
+        for( int j = 0; j < nMax; j++ )
         {
-                if( ((*i >= ' ' && *i <= '9') ||
-                        (*i >= 'a' && *i <= 'z') ||
-                        (*i >= 'A' && *i <= 'Z') ) &&
-                        (*i != '\"' && *i != '\'' && *i != '&')
+                char c = sIn[j];
+                if( ((c >= ' ' && c <= '9') ||
+                        (c >= 'a' && c <= 'z') ||
+                        (c >= 'A' && c <= 'Z') ) &&
+                        (c != '\"' && c != '\'' && c != '&')
                   )
                 {
-                        sOut += *i;
+                        sOut += c;
                 }
                 else
                 {
                         sOut += "&#";
                         char buf[4];
-                        sprintf( buf, "%u", (unsigned char)*i );
+                        sprintf( buf, "%u", (unsigned char)c );
                         sOut += buf;
                         sOut += ';';
                 }
@@ -76,19 +70,19 @@ std::string XmlWriter::escape( std::string sIn )
         return sOut;
 }
 
-void XmlWriter::writeNodeProps( XmlNode *pNode, int nIndent, const char *sIndent )
+void XmlWriter::writeNodeProps( XmlNode *pNode, int nIndent, const Bu::FString &sIndent )
 {
         for( int j = 0; j < pNode->getNumProperties(); j++ )
         {
                 writeString(" ");
-                writeString( pNode->getPropertyName( j ) );
+                //writeString( pNode->getPropertyName( j ) );
                 writeString("=\"");
-                writeString( escape( pNode->getProperty( j ) ).c_str() );
+                //writeString( escape( pNode->getProperty( j ) ).c_str() );
                 writeString("\"");
         }
 }
 
-void XmlWriter::writeNode( XmlNode *pNode, int nIndent, const char *sIndent )
+void XmlWriter::writeNode( XmlNode *pNode, int nIndent, const Bu::FString &sIndent )
 {
         if( pNode->hasChildren() )
         {
@@ -96,15 +90,15 @@ void XmlWriter::writeNode( XmlNode *pNode, int nIndent, const char *sIndent )
                 writeString("<");
                 writeString( pNode->getName() );
                 writeNodeProps( pNode, nIndent, sIndent );
-                if( sIndent )
+                if( sIndent != "" )
                         writeString(">\n");
                 else
                         writeString(">");
-
+/*
                 if( pNode->getContent( 0 ) )
                 {
                         writeIndent( nIndent+1, sIndent );
-                        if( sIndent )
+                        if( sIndent != "" )
                         {
                                 writeString( pNode->getContent( 0 ) );
                                 writeString("\n");
@@ -129,9 +123,9 @@ void XmlWriter::writeNode( XmlNode *pNode, int nIndent, const char *sIndent )
                                         writeString( pNode->getContent( j+1 ) );
                         }
                 }
-                
+*/              
                 writeIndent( nIndent, sIndent );
-                if( sIndent )
+                if( sIndent != "" )
                 {
                         writeString("</");
                         writeString( pNode->getName() );
@@ -143,7 +137,7 @@ void XmlWriter::writeNode( XmlNode *pNode, int nIndent, const char *sIndent )
                         writeString( pNode->getName() );
                         writeString(">");
                 }
-        }
+        }/*
         else if( pNode->getContent() )
         {
                 writeIndent( nIndent, sIndent );
@@ -157,14 +151,14 @@ void XmlWriter::writeNode( XmlNode *pNode, int nIndent, const char *sIndent )
                 writeString(">");
                 if( sIndent )
                         writeString("\n");
-        }
+        }*/
         else
         {
                 writeIndent( nIndent, sIndent );
                 writeString("<");
                 writeString( pNode->getName() );
                 writeNodeProps( pNode, nIndent, sIndent );
-                if( sIndent )
+                if( sIndent != "" )
                         writeString("/>\n");
                 else
                         writeString("/>");